search

ripmeapp2 / ripme

Downloads albums in bulk
MIT License
290 stars 37 forks source link

LusciousRipper non existing method test removed #160

Closed joroto closed 7 months ago

joroto commented 7 months ago

Category

This change is exactly one of the following (please change [ ] to [x]) to indicate which:

Description

Second PR for #154 as the last one (#156) blocked the release build

soloturn commented 7 months ago

merged. you are aware that this was only the test class, as the title says. not fixing a ripper as the text here says? for the backed out pull request, you could create a new branch and cherry pick the commit. depends on the editor you use, for intellij it is like this: https://www.youtube.com/watch?v=plZT7PQtijg, for vscode like this: https://www.youtube.com/watch?v=wIY824wWpu4.

joroto commented 7 months ago

I did not understand what you mean. The previous PR #156 is merged right? I saw you reverted it and then reverted the revert. So the only changes needed were to the test as it was trying to call a method that does not exist, which this PR fixes. Is there anything else I need to do?

soloturn commented 7 months ago

ah, no, all good, i guess. it built red for other tests. of course, if you ask, it would be cool if you fix such tests as well or mark them flaky :) facilitates release ...