search

ripmeapp2 / ripme

Downloads albums in bulk
MIT License
311 stars 38 forks source link

Ignore SSL verification option added #175

Open joroto opened 10 months ago

joroto commented 10 months ago

Category

This change is exactly one of the following (please change [ ] to [x]) to indicate which:

Description

Added the option to ignore SSL verification as this can cause issues on some websites with bad configurations.

Testing

Tested with the link from 171, works as expected.

soloturn commented 8 months ago

thank you so much! would it be possible to have a anme like ssl verify off instead?

joroto commented 8 months ago

Is only the checkbox text enough or do you prefer for it to be renamed throughout the code?

soloturn commented 8 months ago

if you do not mind too much, rename in the code. it makes searching for it and not overlooking instances a little easier.

joroto commented 4 months ago

@soloturn done. I am not sure what #186 point is but I see you have a question there, yes, the issue was motherless urls have an issue with their certificate which was causing the rip to fail.

This new option provides the ability to ignore certificate validation. I checked it by trying to rip a motherless url with and without the option enabled.