ripmeapp2 / ripme

Downloads albums in bulk
MIT License
311 stars 38 forks source link

Fixed Motherless ripper #194

Closed brantspar closed 4 months ago

brantspar commented 4 months ago

The Motherless ripper was broken as the rip operation was not waiting on all the threads created to download the files from motherless.

This repo reminded me as to why OO inheritance is just plain bad... too hard to follow what's happening!

Also

Category

This change is exactly one of the following (please change [ ] to [x]) to indicate which:

Testing

Required verification:

Optional but recommended:

brantspar commented 4 months ago

@soloturn for visibility

brantspar commented 4 months ago

I have fixed the tests however the build ends with this error

Could not create new tag "refs/tags/latest-194-merge" (Resource not accessible by integration) therefore updating existing tag "tags/latest-194-merge"
  Error: Resource not accessible by integration

It looks like it's related to this -> https://github.com/marvinpinto/actions/issues/61 -> The pull requests run with read-only permissions because they are made by other users