search

ripose-jp / Memento

An mpv-based video player for studying Japanese
https://ripose-jp.github.io/Memento/
GNU General Public License v2.0
434 stars 21 forks source link

Subtitle Offset #186

Closed Ryu481 closed 8 months ago

Ryu481 commented 8 months ago

Could you add subtitle offset in the subtitle list like it is in animebook? It would be nice for retiming subtitles.

ripose-jp commented 8 months ago

I haven't used animebook extensively, so I don't know what you're referring to. Please describe your feature request and how it works.

Ryu481 commented 8 months ago

In animebook at the end of the subtitle list you can add an offset +- to time the subtitles, because they are often out of sync. So you can add the time the subtitles are out of sync and it will shift the subtitles for the amount entered. It looks like this https://i.imgur.com/FA5UQYO.png

Erland-Eldrid commented 8 months ago

I haven't used animebook extensively, so I don't know what you're referring to. Please describe your feature request and how it works.

I was gonna open a new issue, but since mine is kinda similar, I decided to comment here.

About the primary and secondary subtitles, is it possible to retime each one independently without affecting the other? For example, the secondary subs are correctly timed, and the primary subs (the Japanese one) are not. But if I retime it by pressing Z or X, it'll affect the secondary subs as well. It'd be really helpful in I could retime each one independently.

ripose-jp commented 8 months ago

@Ryu481 This is already a feature in mpv bound by default to the z and x keys.

@Erland-Eldrid Unfortunately not. If this PR gets merged https://github.com/mpv-player/mpv/pull/11689 then it will be. Nothing's been happening with it for months though.