search

ripose-jp / Memento

An mpv-based video player for studying Japanese
https://ripose-jp.github.io/Memento/
GNU General Public License v2.0
472 stars 22 forks source link

Secondary subtitles do not scale like the primary one #188

Closed bhamon-dot closed 9 months ago

bhamon-dot commented 9 months ago

Hello,

Thanks for Memento :)

Not sure if the problem is on my end but I thought I would ask here.

Pretty much everything is in the title and screenshot below. My understanding is that text scale should also apply to secondary subtitle. Am I wrong ?

image

ripose-jp commented 9 months ago

Secondary subtitles are rendered by mpv, not Memento, so you're bound by what mpv supports. As of now there is no way to scale secondary subtitles in mpv. It's possible to do so in code, I made a proof of concept awhile ago https://github.com/mpv-player/mpv/pull/8954#issuecomment-875888811. That said, I have no intention of properly implementing it.

As of now secondary subtitles exist in mpv as more of a hack than a first class feature, so these kind of issues exist. The entire subtitle backend should be rewritten someday, but I doubt I'll be the one frustrated enough to do it. Having secondary subtitles that I can toggle the visibility of and set the delay of is enough for me.

If you want this feature you should make an issue in mpv. Though learning C and implementing it yourself may be a faster option.

bhamon-dot commented 9 months ago

Alright, makes sense. Thanks for answering!

PS: No way I'm ever doing C again 😂