search

ripose-jp / Memento

An mpv-based video player for studying Japanese
https://ripose-jp.github.io/Memento/
GNU General Public License v2.0
434 stars 21 forks source link

Can't use numpad to adjust volume #195

Closed kimjongbing closed 5 months ago

kimjongbing commented 5 months ago

With this config: LEFT seek -2 exact RIGHT seek 2 exact KP_DIV adjust_volume -5 KP_MULTIPLY adjust_volume 5

I am trying to use "/" and "*" on my numpad to adjust volumes but it does not work. On mpv this is default for me, I have tried adjusting my input.conf to match this but it does not seem to work.

I am on Windows 11.

ripose-jp commented 5 months ago

KP_DIV and KP_MULTIPLY are not valid key names in mpv. However, Memento sends them to mpv with the invalid names of KP/ and KP*. They should be handled as if they were not on the keypad at all since arthritic keys on the numpad don't contain any special KP prefix when being handled by mpv. I've made a commit fixing this.

kimjongbing commented 5 months ago

KP_DIV and KP_MULTIPLY are not valid key names in mpv. However, Memento sends them to mpv with the invalid names of KP/ and KP*. They should be handled as if they were not on the keypad at all since arthritic keys on the numpad don't contain any special KP prefix when being handled by mpv. I've made a commit fixing this.

ok thanks for this, also looking forward to handlebars #79 being added since jpmn mining note doesnt work otherwise