search

ripose-jp / Memento

An mpv-based video player for studying Japanese
https://ripose-jp.github.io/Memento/
GNU General Public License v2.0
472 stars 22 forks source link

Point to automatically updated links to yomichan dictionaries in the README #196

Closed precondition closed 8 months ago

precondition commented 8 months ago

The jmdict-yomitan repo of the moe way (https://github.com/themoeway/jmdict-yomitan) automatically produces up-to-date Yomichan/Yomitan versions of JMDict, JMnedict, and KANJIdic with GitHub actions.

The newer versions provide corrections and ameliorations over the old versions archived in FooSoft's repos. Though, an argument could be made that this is naturally less “stable“ and could break or even be the victim of a supply chain attack.

ripose-jp commented 8 months ago

Considering toasted-nutbread is involved with Yomitan, I think the project will have plenty of longevity and don't mind changing the links in the README. Please fix you commit message to follow the guidelines though.

precondition commented 8 months ago

Changed the commit message