search

ripose-jp / Memento

An mpv-based video player for studying Japanese
https://ripose-jp.github.io/Memento/
GNU General Public License v2.0
434 stars 21 forks source link

QT6 migration causes subtitle position to shift when on screen controller is shown/hidden #212

Closed spacehamster closed 2 months ago

spacehamster commented 2 months ago

Subtitle position is shifted up when the player progress bar is shown during mouse move, and shifts back down when it's hidden again.

This issue seems to only occur after the QT6 migration https://github.com/ripose-jp/Memento/commit/afea4019a6a1c6bb5daa153490ecfa3ce9494a97

image image

ripose-jp commented 2 months ago

That is actually intended behavior if the subtitles are so low the OSC would block their visibility. However it seems to be happening in situations where the OSC would not block subtitles after the Qt 6 migration. I'll look into it.