search

ripose-jp / Memento

An mpv-based video player for studying Japanese
https://ripose-jp.github.io/Memento/
GNU General Public License v2.0
492 stars 21 forks source link

Flag subtitle/timestamp #83

Open ksesong opened 2 years ago

ksesong commented 2 years ago

The ability to flag subtitles or timestamps would allow the watching of videos in its original form, unhindered by pauses or subtitles, while allowing reviews of difficult segments (and possibly vocabulary mining) once the viewing is complete.

Calvin-Xu commented 2 years ago

I take it as you mean marking up certain sections of the video where Memento should behave differently. If this information is to persist after Memento exits and opening it the next time, it needs to go to the disk somehow. I think it might be possible that Memento keeps a new db that stores per video user options, but it might be of pretty marginal value.

unhindered by pauses or subtitles

I think you can just have subtitles hide by default during playback (https://github.com/ripose-jp/Memento/issues/82) and toggle off auto pause (Ctrl P). For sections you want to work on, turn on auto pause and it seems to be the behavior you describe.

ripose-jp commented 2 years ago

It sounds like something that could be implemented as an mpv plugin. Is there any reason Memento should implement it internally?

ksesong commented 2 years ago

In an ideal case, each subtitle flag would be visible in the subtitle list panel, which could then be filtered to only show the flagged subtitles. This would enable a smooth asynchronous mining workflow, where one would flag valuable subtitles with a keyboard/button shortcut during the viewing, and reviewing these problematic subtitles at the end of the session.

Calvin-Xu commented 2 years ago

Have you tried some of the mpv bookmark scripts like this https://github.com/NurioHin/mpv-bookmarker?