search

ripple-unmaintained / ripple-lib-java

Java version of ripple-lib (work in progress)
ISC License
126 stars 109 forks source link

Added the functionality of creating a key pair based off of account numb... #55

Closed cdm6a closed 10 years ago

cdm6a commented 10 years ago

...er or account address as well as from seed bytes.

After thinking about it more and a few of sublimator's comments,I came to the realization that the java version shouldn't mirror the exact behavior of the JS function (because of the different nature of the languages).

Because of the strong typing nature of Java I thought it would be best to let the client of the Seed class determine which method / case they would like to use and eliminate any ambiguity in letting the function determine what the client is sending in.

TODO: Find out exactly what the check should be in the createKeyPairFromAddress should

cdm6a commented 10 years ago

Looks like some sort of command needs to be run on the Travis build related to android to get it successful.

sublimator commented 10 years ago

Hey, yeah, it's fixed on the development branch, which is overdue for merging into master