ripple / crypto-conditions

A Java implementation of Crypto-Conditions (draft-thomas-crypto-conditions)
Apache License 2.0
5 stars 12 forks source link

Fix Javadoc for PreimageSha256Fulfillment.getEncodedPreimage #5

Closed sappenin closed 6 years ago

sappenin commented 6 years ago

The JavaDoc for PreimageSha256Fulfillment#getEncodedPreimage is incorrect. This field has nothing todo with the OER encoding of a PreimageSha256Fulfillment (which is generated using the CryptoConditionsWriter).

Instead, this is just an attempt to help make PreimageSha256Fulfillment more immutable, because returning the actual underlying byte[] allows external actors to mutate the state of a PreimageSha256Fulfillment.