ripple / explorer

Open Source XRP Ledger Explorer
https://livenet.xrpl.org/
MIT License
110 stars 68 forks source link

fix: Upgrade Status renders on data error #1000

Closed pdp2121 closed 4 weeks ago

pdp2121 commented 3 months ago

High Level Overview of Change

The VHS is experiencing an intermittent issue with CORS header that causes occasional disruption in data fetching for the Upgrade Status chart. This PR will add checks so to ensure the chart renders even when there's a disruption.

Screenshot 2024-06-12 at 4 13 54 PM

Type of Change

pdp2121 commented 3 months ago

I will add test cases

pdp2121 commented 2 months ago

@mvadari I have updated the logic. Aggregation for nodes and validators will be handled separately (in case one fails, it would still update the other).

pdp2121 commented 2 months ago

Not sure why npm run test:ci succeed locally but fails on GitHub

mvadari commented 2 months ago

Not sure why npm run test:ci succeed locally but fails on GitHub

Usually due to flakiness or something, or missing an async/await somewhere.