Leverage nftoken_id, nftoken_ids and offer_id meta fields in transaction parsers - Githubissues

ripple / explorer

Open Source XRP Ledger Explorer

https://livenet.xrpl.org/

MIT License

105 stars 66 forks source link

Leverage nftoken_id, nftoken_ids and offer_id meta fields in transaction parsers #1018

Closed achowdhry-ripple closed 1 month ago

achowdhry-ripple commented 1 month ago

High Level Overview of Change

utilize added ID fields based on this rippled PR, rather than manually parsing for NFToken transactions.

Context of Change

https://github.com/ripple/explorer/issues/708

Type of Change

Code Improvement

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Refactor (non-breaking change that only restructures code)
[ ] Tests (You added tests for code that already exists, or your new feature included in this PR)
[ ] Documentation Updates
[ ] Translation Updates
[ ] Release

TypeScript/Hooks Update

[ ] Updated files to React Hooks
[ ] Updated files to TypeScript

achowdhry-ripple commented 1 month ago

for cancel offer, I purposely do not use meta.nftoken_ids[] to keep logic simple, since we iterate nodes for other fields. Seems like added complexity to use the meta field here.