ripple / explorer

Open Source XRP Ledger Explorer
https://livenet.xrpl.org/
MIT License
95 stars 61 forks source link

Unable to see full URI for long NFT URI's #108

Closed JST5000 closed 1 year ago

JST5000 commented 2 years ago

Quoting @andrew-keig-nomena who posted this issue on March 28th in the xrpl.js repo here: https://github.com/XRPLF/xrpl.js/issues/1944

When viewing my transaction on nft-devnet.xrpl.org, I am not able to see the complete IPFS link. Also would it be possible to provide a link to IPFS from here.

Example below:

https://nft-devnet.xrpl.org/transactions/DB45197C3165450FC3A1035C5517E09D0724DC9CF461E18899D2D883AC6FD227

mvadari commented 2 years ago

The link is purposefully not provided, because that could be a potential security issue

JST5000 commented 2 years ago

Not hyperlinking is fine, but this is about how the text just runs off the screen without any way to copy + paste it.

If our goal is to not show the link at all, then we should have a better user interface to demonstrate that. (Ex. "URI hidden for security")

(Although I think that having a plaintext version of the link be fully visible would be better than hiding the URI entirely)

mvadari commented 2 years ago

cc @ledhed2222 - I believe the idea is for it to be in plaintext and fully visible

ledhed2222 commented 2 years ago

Added to our board

ckniffen commented 1 year ago

fixed by #261