fix: align Amendments page On(tx) column to the left.

ripple / explorer

Open Source XRP Ledger Explorer

https://livenet.xrpl.org/

MIT License

111 stars 68 forks source link

fix: align Amendments page On(tx) column to the left. #923

Closed pdp2121 closed 8 months ago

pdp2121 commented 8 months ago

High Level Overview of Change

Align On(tx) column on Amendments table to the left to be consistent with other columns and ensure content are lined up.

Type of Change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Refactor (non-breaking change that only restructures code)
[ ] Tests (You added tests for code that already exists, or your new feature included in this PR)
[ ] Documentation Updates
[ ] Translation Updates
[ ] Release

Before / After

Before

Screenshot 2024-01-25 at 3 39 44 PM

After

Screenshot 2024-01-25 at 3 40 20 PM

ckniffen commented 8 months ago

Does this also look good on mobile?

mvadari commented 8 months ago

While you're on this page, can you please increase the font size a bit?

pdp2121 commented 8 months ago

Does this also look good on mobile? @ckniffen Mobile view:

pdp2121 commented 8 months ago

While you're on this page, can you please increase the font size a bit?

@mvadari we are using the same font size as other tables (Validators & Nodes). I think we want consistency as we have discussed this before

mvadari commented 8 months ago

While you're on this page, can you please increase the font size a bit?

@mvadari we are using the same font size as other tables (Validators & Nodes). I think we want consistency as we have discussed this before

The data is a lot more dense on those tables so the small font feels more justified. As a user, the font on the amendments page legitimately feels too small, since there's a lot less data in the table.