Closed mvadari closed 4 months ago
@bugsbunnies Should the message be something similar to the <NoMatch />
component for cohesiveness?
@bugsbunnies Should the message be something similar to the
<NoMatch />
component for cohesiveness?
I copied the old error message/CSS that was displayed in the Simple
page when it wasn't supported for an unknown transaction, before we added support for a default Simple
page.
@bugsbunnies Should the message be something similar to the
<NoMatch />
component for cohesiveness?I copied the old error message/CSS that was displayed in the
Simple
page when it wasn't supported for an unknown transaction, before we added support for a defaultSimple
page.
Make sense!
@bugsbunnies Should the message be something similar to the
<NoMatch />
component for cohesiveness?
Yeah that makes sense
@bugsbunnies Should the message be something similar to the
<NoMatch />
component for cohesiveness?Yeah that makes sense
IMO the current error message is better, because this would exclusively be due to an Explorer error, rather than user error. But I'm happy to edit the CSS if you'd prefer that.
High Level Overview of Change
This PR has better error handling if there is a bug in a transaction's
Simple
page. This results in better user experience when something is broken.This does add a package,
react-error-boundary
, but the package is very tiny and is quite useful.Context of Change
I encountered this while using the Explorer.
Type of Change
TypeScript/Hooks Update
N/A
Before / After
Before: a black screen
After:![image](https://github.com/ripple/explorer/assets/8029314/62e4645d-13b1-45cd-b50f-709c8de4edad)
Test Plan