search

ripple / explorer

Open Source XRP Ledger Explorer
https://livenet.xrpl.org/
MIT License
97 stars 62 forks source link

fix: move `%` on AMM Account Page #957

Closed mvadari closed 3 months ago

mvadari commented 3 months ago

High Level Overview of Change

This PR moves the % in the trading fee for AMM Account pages, and fixes a couple of deprecated function issues that were noticed in the process.

Context of Change

Noticed while looking at an AMM page.

Type of Change

TypeScript/Hooks Update

N/A

Before / After

Before:

image

After:

image

Test Plan

Works locally.

mrT23 commented 3 months ago

❌ PR-Agent: Missing component name in test command.

Please provide a component name when running the tool: /test <component_name>. Running automatically on the largest changed component.

✨ Test tool usage guide:
The `test` tool generate tests for a selected component, based on the PR code changes. It can be invoked manually by commenting on any PR: ``` /test component_name ``` where 'component_name' is the name of a specific component in the PR. To get a list of the components that changed in the PR, use the [`analyze`](https://pr-agent-docs.codium.ai/tools/analyze/) tool. Language that are currently supported: Python, Java, C++, JavaScript, TypeScript. Configuration options: - `num_tests`: number of tests to generate. Default is 3. - `testing_framework`: the testing framework to use. If not set, for Python it will use `pytest`, for Java it will use `JUnit`, for C++ it will use `Catch2`, and for JavaScript and TypeScript it will use `jest`. - `avoid_mocks`: if set to true, the tool will try to avoid using mocks in the generated tests. Note that even if this option is set to true, the tool might still use mocks if it cannot generate a test without them. Default is true. - `extra_instructions`: Optional extra instructions to the tool. For example: "use the following mock injection scheme: ...". - `file`: in case there are several components with the same name, you can specify the relevant file. - `class_name`: in case there are several components with the same name in the same file, you can specify the relevant class name. See more information about the test tool in the [docs](https://pr-agent-docs.codium.ai/tools/test/).