search

ripple / ripple-binary-codec

Convert between json and hex representations of transactions and ledger entries on the XRP Ledger. Moved to: https://github.com/XRPLF/xrpl.js/tree/develop/packages/ripple-binary-codec
https://github.com/XRPLF/xrpl.js/tree/develop/packages/ripple-binary-codec
ISC License
19 stars 45 forks source link

fix(tickets): Field codes for TicketCount and TicketSequence #111

Closed elmurci closed 3 years ago

elmurci commented 3 years ago

BeginLedgerSeq was taking the place of TicketCount (40) in definitions. From rippled's code TicketCount should be 40 and TicketSequence 41. Also, BeginLedgerSeq doesn't seem to be used, so removing it.

natenichols commented 3 years ago

Would you resolve the merge conflict?

natenichols commented 3 years ago

To fix the CI/CD change the ticket-create-binary.json to 12000A240000000E2028000000016840000000000027108114D5024F157225CA9F8F4C73094D61A8FDD746E0DB

intelliot commented 3 years ago

What is BeginLedgerSeq and where did it come from? @natenichols it looks like you added it here: https://github.com/ripple/ripple-binary-codec/commit/2ffb464dc0ac9cd9896f677a4acd2b9b86c0426e

natenichols commented 3 years ago

This one is totally my bad. While this PR was being reviewed there were some changes made to the PR for negative UNL SFields.cpp

IIRC those changes made UNLModify txs use LedgerSequence instead of BeginLedgerSequence. Looks like it slipped through on the binary-codec PR.

It is not in the rippled code as mentioned above