ripple / ripple-binary-codec

Convert between json and hex representations of transactions and ledger entries on the XRP Ledger. Moved to: https://github.com/XRPLF/xrpl.js/tree/develop/packages/ripple-binary-codec
https://github.com/XRPLF/xrpl.js/tree/develop/packages/ripple-binary-codec
ISC License
19 stars 45 forks source link

X-Address Encoding in Issued Currencies #113

Closed natenichols closed 3 years ago

natenichols commented 3 years ago

High Level Overview of Change

Handle the case when issued currencies have an X-address in the issuer.

Context of Change

We handle the two cases where X addresses can have destination tags in STObject. For the rest of the AccountIDs, if we receive an X address then it cannot have a tag associated with it. This PR implements this functionality in the AccountID::fromBase58

Type of Change

Test Plan

Adds two tests to test this functionality