Closed natenichols closed 3 years ago
Handles the edge case where UInt64 is constructed from string '0'.
UInt64
'0'
When constructing UInt64 with.from(), this adds an edge case when the parameter is of type string where UInt64.from('0') returnsUInt64.from(0).
.from()
UInt64.from('0')
UInt64.from(0)
Added test coverage for this case.
Looks good... could we also add a test case that uses some realistic-ish data from rippled?
Since this is covering a case that only occurs as of rippled v1.7.0+
High Level Overview of Change
Handles the edge case where
UInt64
is constructed from string'0'
.Context of Change
When constructing
UInt64
with.from()
, this adds an edge case when the parameter is of type string whereUInt64.from('0')
returnsUInt64.from(0)
.Type of Change
Test Plan
Added test coverage for this case.