search

ripple / ripple-binary-codec

Convert between json and hex representations of transactions and ledger entries on the XRP Ledger. Moved to: https://github.com/XRPLF/xrpl.js/tree/develop/packages/ripple-binary-codec
https://github.com/XRPLF/xrpl.js/tree/develop/packages/ripple-binary-codec
ISC License
19 stars 45 forks source link

Duplicate FieldID: ValidatorToDisable and ValidatorToReEnable #127

Closed corverroos closed 3 years ago

corverroos commented 3 years ago

As per documentation at https://github.com/ripple/ripple-binary-codec/tree/master/src/enums:

Sort code numbers are reused for fields of different types, but different fields of the same type never have the same sort code. When you combine the type code with the sort code, you get the field's unique Field ID.

The source definition of both ValidatorToDisable and ValidatorToReEnable have a nth:20 and type: Blob

[
      "ValidatorToDisable",
      {
        "nth": 20,
        "isVLEncoded": true,
        "isSerialized": true,
        "isSigningField": true,
        "type": "Blob"
      }
    ],
    [
      "ValidatorToReEnable",
      {
        "nth": 20,
        "isVLEncoded": true,
        "isSerialized": true,
        "isSigningField": true,
        "type": "Blob"
      }
    ],
natenichols commented 3 years ago

@corverroos Thanks for opening this issue!

This change is up in PR #130 if you want to have a look.