ripple / ripple-binary-codec

Convert between json and hex representations of transactions and ledger entries on the XRP Ledger. Moved to: https://github.com/XRPLF/xrpl.js/tree/develop/packages/ripple-binary-codec
https://github.com/XRPLF/xrpl.js/tree/develop/packages/ripple-binary-codec
ISC License
19 stars 45 forks source link

fix: change sfValidatorToReEnable to field code 21 #130

Closed natenichols closed 3 years ago

natenichols commented 3 years ago

High Level Overview of Change

Corrects field code for sfValidatorToReEnable. fixes #127

Context of Change

Field code for sfValidatorToReEnable should be 21. See https://github.com/ripple/rippled/blob/develop/src/ripple/protocol/impl/SField.cpp/#L227

Type of Change

Note: I am personally of the opinion that this can wait to go into the next release, and does not merit its own re-release, as negativeUNL has not been enabled on mainnet yet. Open to other opinions from reviewers.

natenichols commented 3 years ago

@intelliot Yeah, something like that.

Similar to the idea y'all had a while back for generating the definitions.json from the rippled source code.