ripple / ripple-binary-codec

Convert between json and hex representations of transactions and ledger entries on the XRP Ledger. Moved to: https://github.com/XRPLF/xrpl.js/tree/develop/packages/ripple-binary-codec
https://github.com/XRPLF/xrpl.js/tree/develop/packages/ripple-binary-codec
ISC License
19 stars 45 forks source link

Fixes a bug with encoding non-standard currency codes #137

Closed mvadari closed 3 years ago

mvadari commented 3 years ago

This PR throws an error when someone passes the code 585250 (or XRP) as a currency (which is disallowed in the spec). It also cleans up the code a bunch and removes an unused method.

This bug was uncovered via the xrpl-py repo, when someone raised an issue.