search

ripple / ripple-binary-codec

Convert between json and hex representations of transactions and ledger entries on the XRP Ledger. Moved to: https://github.com/XRPLF/xrpl.js/tree/develop/packages/ripple-binary-codec
https://github.com/XRPLF/xrpl.js/tree/develop/packages/ripple-binary-codec
ISC License
19 stars 45 forks source link

add new fields to support NFToken minting and burning #139

Closed ledhed2222 closed 3 years ago

ledhed2222 commented 3 years ago

Title says it all

natenichols commented 3 years ago

Will approve once we have tests for NFT TransactionTypes and LedgerEntries. Fixtures for existing tests are here, and all they do is test binary against JSON. They could use a some cleaning up in the future, but for now they're alright.

You should be able to get the hex encoding for an NFToken, NFTokenMint, and NFTokenBurn from Nik (or Nik's rippled branch) once y'all have a finalized design.

ledhed2222 commented 3 years ago

I'm ok with doing this for the transactions, but it doesn't make sense to me for the lederobjects, as I described in the PR. In the latter case, we're just testing the values of definitions.json and in some cases I found those fixtures aren't actually being tested anywhere.

On Thu, Aug 19, 2021 at 12:16 PM Nathan Nichols @.***> wrote:

Would you add a test similar to what we're doing for other TransactionTypes and LedgerObjects. Fixtures for those tests are [here] ( https://github.com/ripple/ripple-binary-codec/tree/master/test/fixtures).

You should be able to get the hex encoding for an NFToken, NFTokenMint, and NFTokenBurn from Nik (or Nik's rippled branch)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ripple/ripple-binary-codec/pull/139#issuecomment-902047108, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABXUFDJF4RHZ6OAZQ4Y27CTT5UU6RANCNFSM5CJBCXZA .