ripple / ripple-binary-codec

Convert between json and hex representations of transactions and ledger entries on the XRP Ledger. Moved to: https://github.com/XRPLF/xrpl.js/tree/develop/packages/ripple-binary-codec
https://github.com/XRPLF/xrpl.js/tree/develop/packages/ripple-binary-codec
ISC License
19 stars 45 forks source link

switch from yarn to npm #140

Closed ledhed2222 closed 3 years ago

ledhed2222 commented 3 years ago

Title says it all

thejohnfreeman commented 3 years ago

What is driving this change? Is NPM faster and deterministic now?

ledhed2222 commented 3 years ago

hey @thejohnfreeman - yes! npm 7 has determinism. AFAICT, there isn't very strong reasons to choose yarn over npm anymore, other than personal preference. So why make the switch? We have a lot of JS/TS repos we're managing and some are yarn versus npm. It's pretty confusing switching back and forth so we're pushing to standardize with npm.

ledhed2222 commented 3 years ago

@mvadari what do you think about just staging all this stuff in the feature branch and cutting a release after? easier for me to manage that way

mvadari commented 3 years ago

@mvadari what do you think about just staging all this stuff in the feature branch and cutting a release after? easier for me to manage that way

Yeah that's reasonable.