search

ripple / ripple-binary-codec

Convert between json and hex representations of transactions and ledger entries on the XRP Ledger. Moved to: https://github.com/XRPLF/xrpl.js/tree/develop/packages/ripple-binary-codec
https://github.com/XRPLF/xrpl.js/tree/develop/packages/ripple-binary-codec
ISC License
19 stars 45 forks source link

add linting #141

Closed ledhed2222 closed 2 years ago

ledhed2222 commented 3 years ago

this is a MASSIVE PR, I know.

What i've done here is add our @xrplf/eslint-config/base and @xrplf/prettier-config to this repo and resolved 100% of linter errors and warnings. This meant I needed to refactor a lot of stuff, which does IMO result in the package being significantly better. pretty risky PR but I think we can publish this as a beta release and have some folks test on it.

ledhed2222 commented 3 years ago

NOTE - generally I tried to not touch the tests other than simple formatting changes and ensuring that changes made to source are reflected in terms of functionality in the tests. The coverage of the tests SHOULD not have changed here.

natenichols commented 2 years ago

So, other than the comment about the snake-case.ts to camelCase.ts type filenames, I don't have a lot to comment on.

Excited about the changes in this PR, especially changes to abstractions over definitions.json. Definitely cleans up some rough edges.