ripple / ripple-binary-codec

Convert between json and hex representations of transactions and ledger entries on the XRP Ledger. Moved to: https://github.com/XRPLF/xrpl.js/tree/develop/packages/ripple-binary-codec
https://github.com/XRPLF/xrpl.js/tree/develop/packages/ripple-binary-codec
ISC License
19 stars 45 forks source link

Initial change from Babel/JS to TypeScript #70

Closed natenichols closed 4 years ago

natenichols commented 4 years ago

High Level Overview of Change The beginning of migration from Javascript to Typescript

Context of Change This library is outdated. Dependencies need updating and code will be refactored. Migrated all src files to typescript, but didn't modify any functionality or refactor any code. Migrated testing to JestJS, passes all tests. BabelJS removed in favor of Typescript compiling to es5

Type of Change ☐ Bug fix (non-breaking change which fixes an issue) ☐ New feature (non-breaking change which adds functionality) ☐ Breaking change (fix or feature that would cause existing functionality to not work as expected) ☑︎ Refactor (non-breaking change that only restructures code) ☐ Tests (You added tests for code that already exists, or your new feature included in this PR) ☐ Documentation Updates ☐ Release

Before / After The ripple-binary-codec source files are all in typescript. Dependencies and tests have been updated.

Test Plan No additional tests added

Future Plans Refactor each file individually to migrate the library to typescript

Notes

sublimator commented 4 years ago

What a terrible review. Guys just wanted to make “initial” move to TypeScript.