search

ripple / ripple-binary-codec

Convert between json and hex representations of transactions and ledger entries on the XRP Ledger. Moved to: https://github.com/XRPLF/xrpl.js/tree/develop/packages/ripple-binary-codec
https://github.com/XRPLF/xrpl.js/tree/develop/packages/ripple-binary-codec
ISC License
19 stars 45 forks source link

Improve documentation of definitions.json #80

Closed intelliot closed 4 years ago

intelliot commented 4 years ago

Just did a little thinking about the format and made some minor improvements to the readme along the way

sublimator commented 4 years ago

I can’t remember Field ID being a thing back in the day.

intelliot commented 4 years ago

I feel like it might be helpful to consider "nth" to be the "sort code" because it is used for sorting. I think it is already referred to as the sort code in the xrpl.org docs, though not consistently.

natenichols commented 4 years ago

Sort code is probably clearer as it states that ‘nth’ is used for sorting.