Refactored UInt and Derived Classes - Githubissues

ripple / ripple-binary-codec

Convert between json and hex representations of transactions and ledger entries on the XRP Ledger. Moved to: https://github.com/XRPLF/xrpl.js/tree/develop/packages/ripple-binary-codec

https://github.com/XRPLF/xrpl.js/tree/develop/packages/ripple-binary-codec

ISC License

19 stars 45 forks source link

Refactored UInt and Derived Classes #83

Closed natenichols closed 4 years ago

natenichols commented 4 years ago

High Level Overview of Change

Refactored UInt and Derived classes to use class, and in addition

Context of Change

Old code was outdated. Reduced dependencies and updated code.

Type of Change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Refactor (non-breaking change that only restructures code)
[ ] Tests (You added tests for code that already exists, or your new feature included in this PR)
[ ] Documentation Updates
[ ] Release

Before / After

Removed dependency for BN.js in favor of BigInt Migrated makeClass() to class

Test Plan

No new tests added, still passes all test