Convert between json and hex representations of transactions and ledger entries on the XRP Ledger. Moved to: https://github.com/XRPLF/xrpl.js/tree/develop/packages/ripple-binary-codec
Finished refactoring STObject and Amount classes. Now constructed with bytes representation. Cleaned up some types in accordance with linter.
Type of Change
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Refactor (non-breaking change that only restructures code)
[ ] Tests (You added tests for code that already exists, or your new feature included in this PR)
[ ] Documentation Updates
[ ] Release
Before / After
Refactored STObject, Amount, and linted code. Now both classes are constructed using Buffers. Also, renamed SerializedTypeClass -> SerializedType and ComparableClass -> Comparable. Added types to binary-parser.ts and binary-serializer.ts.
Test Plan
All tests still pass. Had to modify SerializedType -> SerializedType.prototype` in test/
High Level Overview of Change
Context of Change
Finished refactoring STObject and Amount classes. Now constructed with bytes representation. Cleaned up some types in accordance with linter.
Type of Change
Before / After
Refactored STObject, Amount, and linted code. Now both classes are constructed using
Buffers. Also, renamedSerializedTypeClass->SerializedTypeandComparableClass->Comparable. Added types tobinary-parser.tsandbinary-serializer.ts.Test Plan
All tests still pass. Had to modify
SerializedType-> SerializedType.prototype` in test/