Finalizing ripple-binary-codec refactor - Githubissues

ripple / ripple-binary-codec

Convert between json and hex representations of transactions and ledger entries on the XRP Ledger. Moved to: https://github.com/XRPLF/xrpl.js/tree/develop/packages/ripple-binary-codec

https://github.com/XRPLF/xrpl.js/tree/develop/packages/ripple-binary-codec

ISC License

19 stars 45 forks source link

Finalizing ripple-binary-codec refactor #88

Closed natenichols closed 4 years ago

natenichols commented 4 years ago

High Level Overview of Change

Finishing the refactor of ripple-binary-codec

Context of Change

Removed ./src/utils folder, none of the utils were used ( Note: also removed bytes-utils.test.js, as a result there will be fewer tests)
Removed dependencies for inherits and lodash
Typed and documented functions and classes.
Linter shows no errors.
Removed make-class from all files.

Type of Change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Refactor (non-breaking change that only restructures code)
[ ] Tests (You added tests for code that already exists, or your new feature included in this PR)
[ ] Documentation Updates
[ ] Release

Before / After

Test Plan

Added no new tests, all tests still pass

Future Tasks

Add protocol buffer support
Compatibility with X-Address format
Generate definitions.json from source code in rippled
Write README.md