ripple / ripple-client

A UI for the Ripple payment network built using web technologies
ISC License
1.34k stars 493 forks source link

Order I never created cost me all my XRP.. #324

Closed evolvo closed 11 years ago

evolvo commented 11 years ago

I was looking at the order book for XRP/BTC when Ripple went offline...when I logged back in 30 seconds later it had created and completed a sell of my ripples for BTC at far below market price and left me with less than the minimum amount. Is there any way to reverse this transaction and get my XRP back or are they gone for good? And what happened exactly? Now I'm left unable to do any transactions on Ripple

r4EM4gBQfr1QgQLXSPF4r7h84qE9mb6iCC is my ripple account

melvincarvalho commented 11 years ago

@evolvo I think you might have done a buy when you wanted to sell? I saw an order come in for about 8 BTC at 64000 XRP ... was this you?

melvincarvalho commented 11 years ago

I was going to write this before, but the buy/sell buttons are easy to mistake. In fact betfair had this same problem when they started. One solution in the UI is to turn the background of the order BLUE when you want to buy, and red/purple when you want to sell. (Red is considered unlucky in finance)

evolvo commented 11 years ago

I'm completely aware of the Buy/Sell issue here...the problem is that I didn't create any offer at ALL..I was browsing through the order books when Ripple went offline..when I came back on it was gone...there was no offer created....so my guess is either a bug or I was hacked?

evolvo commented 11 years ago

and yes..it created an offer for 8.07 BTC for 500,000 + XRP...I again repeat that I did not make any offer since last night which was at 4 BTC...so I'm not sure what happened here...and whoever got my XRP got them at a very good price...and now I have none

kravets commented 11 years ago

One additional data point, at this time http://ripple.com/graph shows his history inverted (oldest entries first) and lots of NaNs at the bottom of this history list

melvincarvalho commented 11 years ago

@evolvo sorry for your loss, I've sent you 350 XRP to get you started again. For the record I got about 1 of your BTC at around 49000 I think, which is roughly the current market price. I'll reverse the trade if you really want to.

evolvo commented 11 years ago

Thank you man. I appreciate that! That 1 BTC transaction must have been a while ago no? There's no reason to reverse that transaction because I recall making it. It was legit. I appreciate the offer though! I really wonder what went on here with this one for 8.07 BTC though because it just doesn't make any sense.

justmoon commented 11 years ago

One solution in the UI is to turn the background of the order BLUE when you want to buy, and red/purple when you want to sell.

Yep, the same thing happened to me while testing. So I suggested the same solution to @elilang last Friday, I expect something like that or something even better will be in the next mockup for that page.

We should also add an extra confirmation if your bid is far above best bid or your ask far below best ask.

evolvo commented 11 years ago

Just to clarify again...that was not the issue here....there was NO offer posted...so this definitely isn't the case of mistaking BUY/SELL...this is something else entirely

ahbritto commented 11 years ago

Investigating.

And this account too: r3ADD8kXSUKHd6zTCKfnKT3zV9EZHjzp1S

ahbritto commented 11 years ago

Account: r4EM4gBQfr1QgQLXSPF4r7h84qE9mb6iCC Transaction: AD70C4DB6BF1E8B36532DE7425865FEE7406757FE7C4510695FC5BFCE384F3FE

An offer to buy 8.07 BTC for 520506.930000 XRP.

evolvo commented 11 years ago

Is that the transaction that I'm speaking of? (I don't know how to search transaction numbers). Can you see what happened? How the order was placed when I didn't place an order and wasn't even in that book at the time?

ahbritto commented 11 years ago

That is the transaction that most recently changed your balance from 303664.042086 XRP to 450.000000 XRP.

The OfferCreate was placed by you or someone with access to your wallet. If it was someone else, they either guessed your wallet name and password or your wallet was compromised in some other way.

https://gist.github.com/5202261.git

evolvo commented 11 years ago

Well It didn't happen from this computer...Ripple went offline and when it logged back in again the XRP were gone...does that mean it was hacked?

justmoon commented 11 years ago

does that mean it was hacked?

The transaction is signed with your private key, that means if it really wasn't you, then someone has your username and password or your master seed. Or perhaps they have or have had access to your computer at some point.