search

ripple / ripple-client

A UI for the Ripple payment network built using web technologies
ISC License
1.34k stars 493 forks source link

Can't send less than 200 xrp to empty accounts #73

Closed jtimon closed 11 years ago

jtimon commented 11 years ago

I have been trying to send some xrp to other accounts I have created and I have been failing for a while despite the "transaction cleared" message. Transactions appear in the history but without modifying the balance. After a while I've discovered that with bigger amounts it works. The problem seems to only reproduce when trying to pay to empty accounts (0 xrp). The "magic number" seems to be between 100 and 200. On failing transactions the fee is still destroyed.

I attach an image with the history:

Screenshot from 2012-12-30 01:35:53

jedmccaleb commented 11 years ago

Stefan: We need some UI for this so people understand what is going on.

vhpoet commented 11 years ago

I have been trying to send some xrp to other accounts I have created and I have been failing for a while despite the "transaction cleared" message.

Now it shows the real message, see #71

jtimon commented 11 years ago

I still see a "You sent X 1 xrp" message. I guess the fix is not deployed yet.

vhpoet commented 11 years ago

you're right, it will be in version 0.1.6

justmoon commented 11 years ago

Now shows a meaningful error. "The destination account does not exist. Too little XRP sent to create it."

In the future we should try to detect this error earlier to avoid wasting the user's money on a fee.

jtimon commented 11 years ago

Wouldn't be nice to include the minimum amount to create an account in the message?

Another thing comes to mind, but I'm not sure it could happen. If you accidentally send xrp (more than 200) to a valid address which doesn't exist on the ledger and you don't own the private key...You would just stupidly lose them, right? Maybe I'm underestimating the users, but a warning prompt before creating an account could save some xrp to someone. Of course, one message could explain it all, although the message may get a little long.

justmoon commented 11 years ago

Wouldn't be nice to include the minimum amount to create an account in the message?

True, I'll add that! Reopening ticket...

Maybe I'm underestimating the users, but a warning prompt before creating an account could save some xrp to someone.

Yes, there are some major changes planned to the send confirm page. Put simply: Right now we're doing sends blindly. In the future we will ask the server for a proposal first, display the proposal (fees, account creation yes/no, ripple path, etc.) to the user so they can decide whether they want to proceed. But this is a bigger change obviously.