Max limit option on offersExercised not respected

donovanhide commented 9 years ago

curl -s 'https://api.ripplecharts.com/api/offersExercised'  -H 'content-type: application/json' --data-binary '{"startTime":"2013-08-12T16:20:59+00:00","endTime":"2015-08-13T16:20:59+00:00","base":{"currency":"XRP"},"counter":{"currency":"USD","issuer":"rMwjYedjc7qqtKYVLiAccJSmCwih4LnE2q"},"reduce":false,"format":"csv","limit":50000}' | wc -l
   50000

DOS vector :-)

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

donovanhide commented 9 years ago

Also, adding distant startTime and endTime values seems to cause the limit to have no effect at all:

curl -s 'https://api.ripplecharts.com/api/offersExercised'  -H 'content-type: application/json' --data-binary '{"startTime":"2012-01-01T16:20:59+00:00","endTime":"2020-01-01T16:20:59+00:00","base":{"currency":"XRP"},"counter":{"currency":"USD","issuer":"rMwjYedjc7qqtKYVLiAccJSmCwih4LnE2q"},"reduced":false,"format":"csv","descending":true,"limit":2}'|wc -l
   15286

shekenahglory commented 9 years ago

thanks, I'll take a look at these, but I'm not sure I will fix everything because we are moving over to data.ripple.com anyways

On Thu, Aug 13, 2015 at 12:05 PM, Donovan Hide notifications@github.com wrote:

Also, adding distant startTime and endTime values seems to cause the limit to have no effect at all:

curl -s 'https://api.ripplecharts.com/api/offersExercised' -H 'content-type: application/json' --data-binary '{"startTime":"2012-01-01T16:20:59+00:00","endTime":"2020-01-01T16:20:59+00:00","base":{"currency":"XRP"},"counter":{"currency":"USD","issuer":"rMwjYedjc7qqtKYVLiAccJSmCwih4LnE2q"},"reduced":false,"format":"csv","descending":true,"limit":2}'|wc -l 15286

— Reply to this email directly or view it on GitHub https://github.com/ripple/ripple-data-api/issues/35#issuecomment-130762374 .

donovanhide commented 9 years ago

Ahh, didn't realise this was all being replaced. The marker in the new API looks a lot better to me:

$ curl -s 'https://data.ripple.com/v2/exchanges/XRP/USD+rMwjYedjc7qqtKYVLiAccJSmCwih4LnE2q/?limit=2&descending=true' |jq '.'
{
  "result": "success",
  "count": 2,
  "marker": "USD|rMwjYedjc7qqtKYVLiAccJSmCwih4LnE2q|XRP||20150813210950|000015239324|00018|00008",
  "exchanges": [
    {
      "base_amount": 37029.69978,
      "counter_amount": 292.13455566164,
      "rate": 0.007889195899433791,
      "autobridged_currency": "USD",
      "autobridged_issuer": "rMwjYedjc7qqtKYVLiAccJSmCwih4LnE2q",
      "buyer": "rD8LigXE7165r3VWhSQ4FwzJy7PNrTMwUq",
      "executed_time": "2015-08-13T21:32:50",
      "ledger_index": 15239649,
      "offer_sequence": 515,
      "provider": "rPPv4WNGttJbdzEgjDqc8bNq7LGCchv2k5",
      "seller": "rPPv4WNGttJbdzEgjDqc8bNq7LGCchv2k5",
      "taker": "rD8LigXE7165r3VWhSQ4FwzJy7PNrTMwUq",
      "tx_hash": "20A2A9B5871F91475FA592CE671E7DE44AAB513732D821BB29CD77FD1C84FD9D",
      "tx_type": "OfferCreate"
    },
    {
      "base_amount": 4546.203061,
      "counter_amount": 35.9104579783849,
      "rate": 0.007899,
      "buyer": "rfaRqwHRF5kPNvFKu7cd2tDavmJHRe38MV",
      "executed_time": "2015-08-13T21:10:20",
      "ledger_index": 15239330,
      "offer_sequence": 182,
      "provider": "rfaRqwHRF5kPNvFKu7cd2tDavmJHRe38MV",
      "seller": "rPPv4WNGttJbdzEgjDqc8bNq7LGCchv2k5",
      "taker": "rPPv4WNGttJbdzEgjDqc8bNq7LGCchv2k5",
      "tx_hash": "B11443922F3C5520B26093B9B7071509F8DE19757DB943D6D610BB6879BF72D3",
      "tx_type": "OfferCreate"
    }
  ]
}

:-)

ripple / ripple-data-api

Max limit option on offersExercised not respected #35