search

ripple / ripple-lib-extensions

[Deprecated] A collection of extensions to ripple-lib. Instead, see https://github.com/XRPLF/xrpl.js
https://github.com/XRPLF/xrpl.js
22 stars 31 forks source link

feat: payment channel detail parser (2) #38

Closed intelliot closed 6 years ago

intelliot commented 6 years ago

I couldn't figure out how to push to the original PR #37 (looks like I don't have permission?) so I'm creating this one. Feel free to copy/use this commit on the original PR (and then we'll just close this one).

To github.com:adrianhopebailie/ripple-lib-extensions.git
 ! [remote rejected] adrianhopebailie/feat/paymentchannels -> adrianhopebailie/feat/paymentchannels (permission denied)
error: failed to push some refs to 'git@github.com:adrianhopebailie/ripple-lib-extensions.git'
sublimator commented 6 years ago

Yeah, just my silly way of pointing it out haha. Seems like snakes met their ladders to heaven :(

Nvm, all in the great tradition of whacking day! Oh whacking day!

intelliot commented 6 years ago

Got an out-of-band approval from @adrianhopebailie so I'm going to merge this, but y'all feel free to open a new issue/PR for further improvements/fixes.

sublimator commented 6 years ago

Haha, I’m not sure anymore :)

I got things confused, perhaps mixing up ripple metadata with the ripple-lib-java helpers which normalize everything to before and after, a useful simplification the majority of the time privided you pay attention to modified vs created.

Will look when on laptop :)

intelliot commented 6 years ago

Thanks! Feel free to open an issue or PR if you spot a problem with my fix.