search

ripple / ripplecharts-frontend

RippleCharts front-end using Angular.js and D3
ISC License
185 stars 132 forks source link

Feature request: render "Expiration" field of Offers in transaction explainer #123

Open mDuo13 opened 8 years ago

mDuo13 commented 8 years ago

Some offers, like this one, seem very mysterious ("success" without doing anything?):

https://www.ripplecharts.com/#/transactions/A6D429DFA83CC2752379203880A680431321F7FDBB6D114E2817D22E10509460

The solution to the mystery is that the offer has an expiration date that's in the past. There are a couple ways the Charts transaction explainer could improve this:

  1. Show the Expiration time in the "Description" tab.
  2. In the "Raw" tab, show the Expiration field's value in ISO format (in addition or instead of showing it in seconds since the Ripple epoch)

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/33003244-feature-request-render-expiration-field-of-offers-in-transaction-explainer?utm_campaign=plugin&utm_content=tracker%2F627456&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F627456&utm_medium=issues&utm_source=github).
shekenahglory commented 8 years ago

So Expiration is a ripple Epoch timestamp?

nbougalis commented 8 years ago

Yes - same as the ledger timestamp.