search

ripple / ripplecharts-frontend

RippleCharts front-end using Angular.js and D3
ISC License
185 stars 132 forks source link

Rounding is producing misleading rates #136

Open marsface opened 8 years ago

marsface commented 8 years ago

The rounding scheme is producing differences that are not negligible, please see this pic. capturar

Even in a small screen size there is plenty of space to show more significant algarisms. Would you agree that maybe the precision should be locked to 2 decimal places if the rate is bigger than 1000?

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/36467990-rounding-is-producing-misleading-rates?utm_campaign=plugin&utm_content=tracker%2F627456&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F627456&utm_medium=issues&utm_source=github).
shekenahglory commented 8 years ago

The rounding is supposed to target 5 significant digits I think, like the bid side - this may be a bug. can you tell me what currency pairs you are looking at?

marsface commented 8 years ago

BTC.rvYAfWj5gh67oV6fW32ZzP3Aw4Eubs59B/XRP and BTC.rvYAfWj5gh67oV6fW32ZzP3Aw4Eubs59B/BRL.rfNZPxoZ5Uaamdp339U9dCLWz2T73nZJZH

Haven't tested any other pair.