search

ripple / rippled-historical-database

SQL database as a canonical source of historical data
99 stars 68 forks source link

Inconsistent formatting of timestamps (bis) #124

Closed aldur closed 7 years ago

aldur commented 7 years ago

(Similar in some ways to #89)

A request to get all the validators returns the following data:

$ curl https://data.ripple.com/v2/network/validators | jq
# ...
    {
      "domain_state": "AccountDomainNotFound",
      "last_datetime": "2016-04-20T20:07:02.105Z",
      "validation_public_key": "n9MqYNiCydizzjMZCWpXbvQgQbjhLdw945iZ2cR52ifL6YLLhbYa"
    }
# ...

The last_datetime field does not respect the conventions specified in https://github.com/ripple/rippled-historical-database#timestamps, since it contains the milliseconds after the period (?).

shekenahglory commented 7 years ago

This is because in this case, we get multiple reports of validations per second, so we need to include milliseconds