ripple / validator-history-service

Service for ingesting, aggregating, storing, and disbursing XRP Ledger validation related data.
ISC License
14 stars 8 forks source link

feat: add validators voting data to db #101

Closed pdp2121 closed 12 months ago

pdp2121 commented 1 year ago

High Level Overview of Change

On every most recent flag ledger, store for each validator into ballot table:

This is to get amendment voting status and later fee votes.

Type of Change

Future Tasks

pdp2121 commented 1 year ago

I will continue to monitor the code locally (looked good till now). Pushed this to get some feedback.

pdp2121 commented 1 year ago

There needs to be an API endpoint to access this data

Yes, that would be the upcoming PR. We separated this into smaller tasks

intelliot commented 1 year ago

There needs to be an API endpoint to access this data

Yes, that would be the upcoming PR. We separated this into smaller tasks

That's good, but you should note this in the "Future Tasks" section of the PR description template.

pdp2121 commented 1 year ago

There needs to be an API endpoint to access this data

Yes, that would be the upcoming PR. We separated this into smaller tasks

That's good, but you should note this in the "Future Tasks" section of the PR description template.

I have updated the description to include future tasks. Thanks Elliot!

pdp2121 commented 1 year ago

@mvadari @ckniffen I have added fee data for validators that do not vote for a fee changed in the latest commit. Please let me know if it looks good, then we can test on staging