feat: Add amendments to validators endpoint

ripple / validator-history-service

Service for ingesting, aggregating, storing, and disbursing XRP Ledger validation related data.

ISC License

14 stars 8 forks source link

feat: Add amendments to validators endpoint #104

Closed pdp2121 closed 11 months ago

pdp2121 commented 1 year ago

High Level Overview of Change

Add voting data to validators related endpoints.

Type of Change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Refactor (non-breaking change that only restructures code)
[ ] Tests (You added tests for code that already exists, or your new feature included in this PR)
[ ] Documentation Updates
[ ] Release

Ready to review when #101 merged.

ckniffen commented 1 year ago

We also need an overall voting information and to know which amendments are enabled.

Additionally a look up for information on amendments might be very nice. Right now the explorer has weird logic where it parses the documentation site and a rippled cpp file.

ckniffen commented 1 year ago

Here is where that happens. https://github.com/ripple/explorer/blob/staging/src/containers/shared/amendmentUtils.ts#L32-L49 and https://github.com/ripple/explorer/blob/staging/src/containers/shared/amendmentUtils.ts#L72-L90

pdp2121 commented 1 year ago

Here is where that happens. https://github.com/ripple/explorer/blob/staging/src/containers/shared/amendmentUtils.ts#L32-L49 and https://github.com/ripple/explorer/blob/staging/src/containers/shared/amendmentUtils.ts#L72-L90

Thanks Caleb, I was also thinking about parsing the doc site for amendment info, but not sure about rippled file. Will examine these codes