fix: validator report timestamp

pdp2121 commented 5 months ago

High Level Overview of Change

There was a bug in response format for individual validator reports (/validator/{pubkey}/reports) that caused the date to be in the future for timezone later than UTC. Set the hour of the date to be 0 instead of 23 would fix this issue, and also correspond with how daily scores save their dates and the /validator_reports.

Addressing https://github.com/ripple/validator-history-service/issues/194

Type of Change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Refactor (non-breaking change that only restructures code)
[ ] Tests (You added tests for code that already exists, or your new feature included in this PR)
[ ] Documentation Updates
[ ] Release

Test Plan

The effect of this change has been tested locally by changing browser's timezone

Future Tasks

Date time on the Explorer should all be in UTC with a specified note to ensure consistency in the data that users in various regions see.

mvadari commented 5 months ago

Will this work okay when it changes and isn't starting from scratch?

pdp2121 commented 5 months ago

Will this work okay when it changes and isn't starting from scratch?

@mvadari The dates in the database are already zeroed out. This change does not affect data in db, just on api side when it convert the date so I don't think it would have any significant effect when we deploy halfway (at least on VHS and Explorer, not sure about other apps using this api)

ripple / validator-history-service