search

ripple / validator-history-service

Service for ingesting, aggregating, storing, and disbursing XRP Ledger validation related data.
ISC License
14 stars 7 forks source link

build(deps): Bump xrpl from 2.13.0 to 3.0.0 #207

Closed dependabot[bot] closed 1 week ago

dependabot[bot] commented 5 months ago

Bumps xrpl from 2.13.0 to 3.0.0.

Release notes

Sourced from xrpl's releases.

xrpl@3.0.0

What's Changed

Migration Guide

BREAKING CHANGES

  • Bump typescript to 5.x
  • Remove Node 14 support
  • Remove crypto polyfills, create-hash, elliptic, hash.js, and their many dependencies in favor of @noble/hashes and @nobel/curves
  • Remove bip32 and bip39 in favor of @scure/bip32 and @scure/bip39
  • Remove assert dependency. If you were catching AssertionError you need to change to Error
  • Configuring a proxy:
    • Instead of passing various parameters on the ConnectionsOptions you know specify the agent parameter. This object can use be created by libraries such as https-proxy-agent or any that implements the http.Agent.
    • This was changed to both support the latest https-proxy-agent and to remove the need to include the package in bundlers. Tests will still be done using https-proxy-agent and only tested in a node environment which was the only way it was previously supported anyway
  • Remove BroadcastClient which was deprecated
  • Uses @xrplf/secret-numbers instead of xrpl-secret-numbers
  • Improve key algorithm detection. It will now throw Errors with helpful messages
  • Move authorizeChannel from wallet/signer to wallet/authorizeChannel to solve a circular dependency issue.
  • When using a bundler you must remove the mapping of ws to WSWrapper. ex. ws: 'xrpl/dist/npm/client/WSWrapper'. See [../UNIQUE_STEPS](https://github.com/XRPLF/xrpl.js/blob/HEAD/Unique Steps) for the new, much smaller, configs.
  • Transaction type has been redefined to include all transactions and SubmittableTransaction was created to define the old value. The following functions which only handle transactions to be submitted now use SubmittableTransaction:
    • Client.autofill
    • Client.submit
    • Client.submitAndWait
    • Client.prepareTransaction
    • getSignedTx
    • isAccountDelete
  • dropsToXRP and Client.getXrpBalance now return a number instead of a string
  • Buffer has been replaced with UInt8Array for both params and return values. Buffer may continue to work with params since they extend UInt8Arrays.

Bundling Changes

Bundler configurations are much more simplified. See [../UNIQUE_STEPS](https://github.com/XRPLF/xrpl.js/blob/HEAD/Unique Steps) for the new, much smaller, configs.

  • removed the following polyfills:
    • buffer
    • assert
    • crypto-browserify
    • https-browserify
    • os-browserify
    • process
    • stream-browserify
    • stream-http
    • url
    • util - previously added automatically by webpack
    • events - previously added automatically by webpack but manual for vite**
  • Removed mappings for:
    • ws to WsWrapper
    • Excluding https-proxy-agent

Non-Breaking Changes

  • Deprecated:
    • convertHexToString in favor of @xrplf/isomorphic/utils's hexToString

... (truncated)

Commits


Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

mvadari commented 4 months ago 
Error: src/shared/types/index.ts(51,11): error TS2430: Interface 'LedgerResponseCorrected' incorrectly extends interface 'LedgerResponse'.
  The types of 'result.ledger' are incompatible between these types.
    Type 'LedgerBinary | LedgerCorrected' is not assignable to type 'LedgerBinary'.
      Type 'LedgerCorrected' is not assignable to type 'LedgerBinary'.
        Types of property 'accountState' are incompatible.
          Type 'LedgerEntry[] | undefined' is not assignable to type 'string[] | undefined'.
            Type 'LedgerEntry[]' is not assignable to type 'string[]'.
              Type 'LedgerEntry' is not assignable to type 'string'.
                Type 'AccountRoot' is not assignable to type 'string'.
dependabot[bot] commented 1 week ago

Superseded by #251.