search

ripple / validator-history-service

Service for ingesting, aggregating, storing, and disbursing XRP Ledger validation related data.
ISC License
14 stars 8 forks source link

Add status error codes to responses #66

Open ckniffen opened 1 year ago

ckniffen commented 1 year ago

Error responses from the VHS always return a status of 200. We should leverage 404 and 500s at the very least.

404 example https://github.com/ripple/validator-history-service/blob/main/src/api/routes/v1/validator.ts#L233 500 example https://github.com/ripple/validator-history-service/blob/main/src/api/routes/v1/validator.ts#L275

sohammk08 commented 11 months ago

Is this issue still valid? And if yes, should I work on it?

mvadari commented 11 months ago

I believe so, and sure