fix: use most updated network for validators

ripple / validator-history-service

Service for ingesting, aggregating, storing, and disbursing XRP Ledger validation related data.

ISC License

14 stars 8 forks source link

fix: use most updated network for validators #76

Closed pdp2121 closed 1 year ago

pdp2121 commented 1 year ago

High Level Overview of Change

Validators table is updating networks with comma-separated. This change will keep only the most updated one.

Type of Change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Refactor (non-breaking change that only restructures code)
[ ] Tests (You added tests for code that already exists, or your new feature included in this PR)
[ ] Documentation Updates
[ ] Release

mvadari commented 1 year ago

lgtm, assuming it fixes the issue in staging - holding off on ✅ until then

ckniffen commented 1 year ago

Is #53 also needed? I think it makes sense to combine with it.

pdp2121 commented 1 year ago

Is #53 also needed? I think it makes sense to combine with it.

Yes I think it makes sense to just keep one network for both nodes and validators. @mvadari what do you think?

mvadari commented 1 year ago

Is #53 also needed? I think it makes sense to combine with it.

Yes I think it makes sense to just keep one network for both nodes and validators. @mvadari what do you think?

I agree - we should just use the same policy for both. Though I do think it'll be easier to test in prod if we only use this policy for one of the two for a couple months, just to see how it looks.

pdp2121 commented 1 year ago

Is #53 also needed? I think it makes sense to combine with it.

Yes I think it makes sense to just keep one network for both nodes and validators. @mvadari what do you think?

I agree - we should just use the same policy for both. Though I do think it'll be easier to test in prod if we only use this policy for one of the two for a couple months, just to see how it looks.

Okay I will deploy this first and hold off on #53 for like a month to see how it goes.