search

riptano / ComboAMI

The AMI takes a set of input parameters via the EC2 user-data to install, RAID, ring, and launch a DataStax Enterprise/Community cluster.
69 stars 59 forks source link

fixing a duplicate description on the --raidonly option and index message offsets #41

Closed jiminoc closed 10 years ago

jiminoc commented 10 years ago

--email and --raidonly had the same descriptions in the comments

the 0 index was duplicated for the reflector status message

need a try/catch around the userdata call as that data isn't available in a VPC and throws a 404

joaquincasares commented 10 years ago

Could we not include commit: eeed1cce08593074f69c826ab962a7a0a9899c81? When you submitted the last patch I realized that status didn't need to have the [INFO] text and made it a bit cleaner.

Also, it doesn't seem as though this pull request will merge correctly. Can you rebase and ensure it's good to merge?

Thanks!

jiminoc commented 10 years ago

sure do you want eeedlcc with just the {0} to {3} fix then or you already have that patched to 2.5?

joaquincasares commented 10 years ago

It seems like it's already patched here: https://github.com/riptano/ComboAMI/blob/2.5/ds2_configure.py#L445

I believe I took your commit and pushed the changes to both branches at the time.

jiminoc commented 10 years ago

closing this one, opened a new clean one from the company fork