search

riptano / ComboAMI

The AMI takes a set of input parameters via the EC2 user-data to install, RAID, ring, and launch a DataStax Enterprise/Community cluster.
69 stars 59 forks source link

Ec2 snitch should be default for AMI with Enterprise #67

Closed chezbut closed 9 years ago

chezbut commented 9 years ago

Looking at https://github.com/riptano/ComboAMI/blob/28686c4753c2d684b8c539d9773f4cc716ed2b5c/ds2_configure.py#L614 - it sets up ec2snitch in the yaml only when it detects the Community version. This should be default for Enterprise, or at least selectable via User-Data.

mlococo commented 9 years ago

Good call, I can't think of any reason why that snitch should be restricted to Community. Will remove that type check at the next update, or I'd happily merge a PR if you wanted to test it out first.

mbulman commented 9 years ago

Just fyi, this could be an artifact from past versions of DSE requiring DseDelegateSnitch in cassandra.yaml, which would make that line NOOP in every case. That has since been changed (as of DSE 4.6 I believe)

joaquincasares commented 9 years ago

Choosing the EC2Snitch for community over SimpleSnitch makes sense since we're in EC2. However, we let DSE use the default DSESimpleSnitch which automatically assigns the datacenter based on the type of workload the node will handle.

A pull request for having EC2Snitch be the default wouldn't gain you much since the AMIs will have to be started in the same region and availability zone either way in order for the automatic provisioning to take place. At that point, you may be stuck with a single data center with Cassandra, Analytics, and/or Search workload types mixed together.

What use case were you looking at @chezbut ?

mlococo commented 9 years ago

Closing this, ec2snitch isn't the right default for enterprise.