riptano / ComboAMI

The AMI takes a set of input parameters via the EC2 user-data to install, RAID, ring, and launch a DataStax Enterprise/Community cluster.
69 stars 59 forks source link

Bump JDK version #76

Closed arodrime closed 9 years ago

arodrime commented 9 years ago

I just received an email from Datastax today:

"DATASTAX SUPPORT ALERT - May 5, 2015

On an instance created from the AMI "datastax_clustering_ami_2.5.1_hvm.manifest.xml (ami-7f33cd08)" which I believe depend on this code, I have this:

"root@ip-10-0-2-56:~# uname -r 3.8.0-37-generic root@ip-10-0-2-56:~# java -version java version "1.7.0_51" Java(TM) SE Runtime Environment (build 1.7.0_51-b13) Java HotSpot(TM) 64-Bit Server VM (build 24.51-b03, mixed mode)"

So the kernel is quite old but new enough to handle the leap second (and I already opened an issue about it https://github.com/riptano/ComboAMI/issues/58).

Yet the JDK version seems to be bellow the one advised by Datastax. I guess we should bump it here directly. I am not sure what version we should use, so I son't propose a PR.

If you don't do it in here I will bump it in my deploy process, but I wanted to let you know.

C*heers,

Alain

mlococo commented 9 years ago

@arodrime Thanks for the report. We have a rebake coming up "Real Soon Now", and will address. As to the JDK version, it should be the most recent in the 1.7 series. I'm not actually familiar with how we do the JDK yet, whether it's a manual part of the bake or automated somewhere in the code. If you submit a PR to update to the latest Java 1.7, I'll merge it. Otherwise, I'll look into it prior to the rebake.

arodrime commented 9 years ago

Hi @mlococo,

I took a few minutes to have a look at this and find java is installed here: https://github.com/riptano/ComboAMI/blob/e38ae0d930d40b730ad888e02eda4743abd60be8/presetup/pre_1.sh#L-34-35

Actually this should do the job. When I re-run this on a machine created a few days ago through this AMI, the jdk is updated to "build 1.7.0_80-b15".

Not sure why this doesn't work actually. @joaquincasares any clue on this ?

C*heers

joaquincasares commented 9 years ago

We are prebaking the Java version since 1.7 was pretty young at the time and we didn't want to get into a bad release (early .10-.22 days).

If we rebake we'll have the newest version today, but I'm open to a pull request where we not only bake the newest at the time, but upgrade to the newest JDK at launch time in ds2().

arodrime commented 9 years ago

PR opened, is that what you expected https://github.com/riptano/ComboAMI/pull/78 ?

arodrime commented 9 years ago

By the way, I just test to update using this same commande on a running machine and it works. No need of any reboot FWIW (if you want to communicate about updating Java for the leap second or whatever).

mlococo commented 9 years ago

We're going to overhaul the way we build images for 2.6 using packer, and we'll bake in the most recent Java7 available at the time of the bake (currently 1.7.0_80-b15). I'm going to go ahead and close this ticket and the PR since this update will happen automatically during the AMI build process.

mlococo commented 9 years ago

See #79 for progress on the packer-based AMI build process.