riptano / ComboAMI

The AMI takes a set of input parameters via the EC2 user-data to install, RAID, ring, and launch a DataStax Enterprise/Community cluster.
69 stars 59 forks source link

update DataStax key #87

Closed tbarbugli closed 9 years ago

tbarbugli commented 9 years ago

seem like the pub key changed, got this one from here: http://debian.datastax.com/debian/repo_key

potential fix for #86

kareblak commented 9 years ago

LGTM. Pretty urgent one.

tbarbugli commented 9 years ago

@kareblak did you try the key? it worked for me but I did not try it from a clean AMI

kareblak commented 9 years ago

@tbarbugli I'm not very friendly with Packer, and didn't manage to create an AMI with the patch. If you can provide me some ./gopackgo.sh flags that'll work, I'll test it out right away on a fresh AMI. Or a new manifest.

tbarbugli commented 9 years ago

@kareblak I guess the fastest way to test this is to change https://github.com/riptano/ComboAMI/blob/2.6/build/provision.sh#L105 to clone a forked git repo with the new key and then run packer. I unfortunately have no time for this today :(

kareblak commented 9 years ago

@tbarbugli Yup, that's what I tried to do.

mlococo commented 9 years ago

Thanks for the PR, I'm going to close this unmerged because PR's should be against dev-2.6. This does look like the correct code, fix, though and after investigating to see if I can fix this without a rebake I'll likely recommit this same diff against dev-2.6 and then rebake a 2.6.2 release.

kareblak commented 9 years ago

@mlococo When do you see 2.6.2 being released?

mlococo commented 9 years ago

@kareblak Let's keep discussion surrounding this issue in #86. I've been providing updates there in realtime, and actively working toward a fix.

There is already a workaround which doesn't require a rebake, just passing in an extra userdata flag.