search

riptano / ccm

A script to easily create and destroy an Apache Cassandra cluster on localhost
Apache License 2.0
1.22k stars 303 forks source link

Update config after setting datadirs so that it persists when populating nodes #597

Closed juiceblender closed 7 years ago

juiceblender commented 7 years ago

Hello,

I noticed that when I create a cluster like so: ccm create test --datadirs=3

After I populate the cluster with nodes, the nodes still come up with only 1 data directory (data0). Digging into it it looks like cluster.conf only has datadirs: 1, and that seems to be because when we first create the cluster after we set the number of datadirs we do not update cluster.conf. (See cluster_cmds.py:ClusterCreateCmd.run).

I believe this fixes it, feel free to let me know if there is any feedback.

Thanks!

juiceblender commented 7 years ago

Hm - the failed build on travis-ci doesn't look like a by-product of the PR, anyone able to elaborate/point me in the right direction?

ptnapoleon commented 7 years ago

Ahh, I broke the travis build on Friday, its not your fault.

+1

juiceblender commented 7 years ago

Thank you very much!