search

riptano / ccm

A script to easily create and destroy an Apache Cassandra cluster on localhost
Apache License 2.0
1.22k stars 303 forks source link

Support byteman startup scripts when calling start() #622

Closed ostefano closed 7 years ago

ostefano commented 7 years ago

I am working on a new test in cassandra-dtest where I need to submit a byteman rule to a single node, after restarting it. Might not be the best way, so I am open to suggestions.

ptnapoleon commented 7 years ago

Hi @ostefano. Forgive me, but I don't really know how the byteman integration in C* works. Why can't you simply set node.byteman_startup_script before calling start()?

ostefano commented 7 years ago

Hi @ptnapoleon , that would not work because byteman_startup_script needs to be part of the configuration file, and setting the class member does not update it (it is only updated when __update_envfile is called by the node constructor).

ptnapoleon commented 7 years ago

Okay. Then, for code re-uses sake, maybe let's just add a method node.update_startup_byteman_script that changes the class member and runs __update_envfile (or import_config_files)?

ostefano commented 7 years ago

Sure, sounds good to me. Pushed commit e70cd78